Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gamelift): add MatchmakingConfiguration L2 Construct for GameLift #23326

Merged
merged 20 commits into from
Jan 3, 2023
Merged

feat(gamelift): add MatchmakingConfiguration L2 Construct for GameLift #23326

merged 20 commits into from
Jan 3, 2023

Conversation

stevehouel
Copy link
Contributor

@stevehouel stevehouel commented Dec 13, 2022 •
edited
Loading

Following aws/aws-cdk-rfcs#436 I have written the Gamelift QueuedMatchmakingConfiguration and StandaloneMatchmakingConfiguration L2 constructs which create all related resources.

All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 13, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team December 13, 2022 14:58
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK p2 labels Dec 13, 2022
@HBobertz HBobertz self-assigned this Dec 16, 2022
HBobertz
HBobertz reviewed Dec 27, 2022
View reviewed changes
Copy link
Contributor

@HBobertz HBobertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments but looks good to me. Going to pass this off for a second opinion just to be sure

packages/@aws-cdk/aws-gamelift/lib/matchmaking-ruleset.ts Show resolved Hide resolved
packages/@aws-cdk/aws-gamelift/lib/matchmaking-configuration.ts Show resolved Hide resolved
packages/@aws-cdk/aws-gamelift/lib/standalone-matchmaking-configuration.ts Show resolved Hide resolved
comcalvi
comcalvi previously requested changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@comcalvi comcalvi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only cosmetic comments, this PR looks really good! I haven't reviewed the API in depth, since I don't have the context for this. The testing that you've added is top notch. I'm going to tag @otaviomacedo, since he was in charge of the RFC and is in a much better place to review the API than I am.

packages/@aws-cdk/aws-gamelift/lib/matchmaking-configuration.ts Show resolved Hide resolved
packages/@aws-cdk/aws-gamelift/lib/matchmaking-configuration.ts Show resolved Hide resolved
packages/@aws-cdk/aws-gamelift/lib/matchmaking-configuration.ts Show resolved Hide resolved
packages/@aws-cdk/aws-gamelift/lib/matchmaking-ruleset.ts Show resolved Hide resolved
packages/@aws-cdk/aws-gamelift/lib/queued-matchmaking-configuration.ts Show resolved Hide resolved
packages/@aws-cdk/aws-gamelift/lib/standalone-matchmaking-configuration.ts Show resolved Hide resolved
packages/@aws-cdk/aws-gamelift/test/queued-matchmaking-configuration.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-gamelift/test/queued-matchmaking-configuration.test.ts Outdated Show resolved Hide resolved
otaviomacedo
otaviomacedo reviewed Dec 27, 2022
View reviewed changes
Copy link
Contributor

@otaviomacedo otaviomacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't have anything to add to what the other reviewers have done.

@mergify mergify bot dismissed comcalvi’s stale review January 3, 2023 08:35

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jan 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bf74937
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9b2573b into aws:main Jan 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@stevehouel stevehouel deleted the houes/rfc-436-matchmakingconf branch January 4, 2023 07:53
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviomacedo otaviomacedo otaviomacedo left review comments

@HBobertz HBobertz HBobertz approved these changes

@comcalvi comcalvi comcalvi left review comments

Assignees

@HBobertz HBobertz

Labels
p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stevehouel @aws-cdk-automation @otaviomacedo @HBobertz @comcalvi